[TYPO3-core] RFC: #16134: TYPO3 doesn't always fix permissions for new files

[Tolleiv.Nietsch]

Am 06.12.2010 23:26, schrieb Christian Kuhn:
>
> Actually, it's not *that* hard, see attached tests. My personal rule of
> thumb is to add unit test to t3lib_div for every change I do, if
> possible. I've also added tests for t3lib_iconworks and t3lib_lock and
> just left out thumbs.php as it's currently untestable without further
> actions taken.
>

You're right that adding tests whenever the functions are touched is a 
good policy, but with these tests the least significant part of these 
functions is tested and all the rest still remains untested.
Atm. that's fine with me, but overall I find it a bit confusing that 
these kind of testing is considered to be useful ~ especially without 
beeing able to mock the fixPermission itself :/.

Anyways I'm going to test it tomorrow - did you find/add any other 
places where the fixPermissions() was added?

Cheers,
Tolleiv
-- 
Tolleiv Nietsch
www.tolleiv.de - www.aoemedia.de
Twitter: http://www.twitter.com/tolleiv