[TYPO3-core] RFC #16676: Code cleanup: Image position "Beside text" is handled in a slightly odd way

[Mikkel Ricky]

This is an SVN patch request.

Type: Code cleanup

Bugtracker references: http://bugs.typo3.org/view.php?id=16676

Branches: TYPO3_4-4 & trunk

Problem:
When using image positions "Beside text, right" (tt_content.imageorient 
= 25) and "Beside text, left" (imageorient = 26) the header has to be 
placed in a position different from the position when using other image 
positions (e.g. "In text, right").

However, the typoscript for handling this is based on "isLessThan" and 
"isGreaterThan" with the effect that *all* image positions with 
"imageorient" greater than 24 will be handled as "Beside text".

Solution:
I suggest a change in EXT:css_styled_content/static/setup.txt to handle 
this specifically for the imageorient-values 25 and 26:

   tt_content.textpic {
     ...
     10.if.value = 25,26
     10.if.isInList.field = imageorient
     10.if.negate = 1
     ...

     20 {
       text.10 {
         if.value = 25,26
         if.isInList.field = imageorient
         ..
       }
       ...
     }
   }

Notes:
This change will make it easy to add new "Beside text" image positions 
and also make it easier to add new "In text" positions using 
"imageorient" values greater than 26.


Best regards,
Mikkel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_16676.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101205/8fec18a1/attachment.asc>