[TYPO3-core] FYI #15601: Change all core PHP files to UTF8 encoding

Ernesto Baschny [cron IT] ernst at cron-it.de
Mon Aug 30 20:57:59 CEST 2010


Hi,

FYI, the following patch has been commited to the core.

Type: Code cleanup

BT reference: http://bugs.typo3.org/view.php?id=15601

Branches: trunk


Problem:
We want to have UTF8 PHP files in order to give proper credit to authors
containing non-ASCII characters in their names. This mostly affects PHP
comments.


Solution:

Attached shell script converted the *.php and *.inc files to UTF8, changed
the names of known authors to their UTF8 variant. 

After applying the patch, each change was manually checked, and here are
the comment for the changes that were made:

tests/t3lib/db/t3lib_db_preparedstatementTest.php
	cannot be converted yet (would change functionality)

tests/t3lib/cache/frontend/t3lib_cache_frontend_abstractfrontendTest.php
	cannot be converted yet (would change functionality)

t3lib/class.t3lib_cs.php
	comments broken since rev.415, fixed

t3lib/thumbs.php
	uses a string to generate a thumbnail for a TTF file.
	This string can contain UTF-8 and works as expected after
	this change

t3lib/class.t3lib_browsetree.php
	file was utf8 already

t3lib/class.t3lib_treeview.php
	file was utf8 already

typo3/sysext/lowlevel/clmods/class.cleanflexform.php
typo3/sysext/lowlevel/clmods/class.deleted.php
typo3/sysext/lowlevel/clmods/class.double_files.php
typo3/sysext/lowlevel/clmods/class.lost_files.php
typo3/sysext/lowlevel/clmods/class.missing_files.php
typo3/sysext/lowlevel/clmods/class.missing_relations.php
typo3/sysext/lowlevel/clmods/class.orphan_records.php
typo3/sysext/lowlevel/clmods/class.rte_images.php
typo3/sysext/lowlevel/clmods/class.versions.php
	files were utf8 already

typo3/sysext/cms/tslib/class.tslib_pagegen.php
	left Kasper's name in ASCII on the call to $pageRenderer->addInlineComment
	because this is outputted in the frontend and is broken if site is not
	UTF-8.

typo3/sysext/*/ext_emconf.php
	Left Kasper's name in ASCII in 'author', because EM is not aware of 
	charsets in this field and it breaks EM display on non-utf8 sites

Apart that I skipped sysext/fluid/ and sysext/extbase/, as they have
been using UTF8 all along and also sysext/adodb/adodb/ which comes 
from external sources.


Cheers,
Ernesto


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: convert-core-utf8.sh
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100830/2b963442/attachment-0001.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 15601.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100830/2b963442/attachment-0001.txt>


More information about the TYPO3-team-core mailing list