[TYPO3-core] RFC #15294: Bug: treeFilterReset disappears + minor optimization

[Felix Kopp — PHORAX]

Hey Steffen & all the others,

alright I have now attached the discussed version (2).
Let me describe and summarize all included changes:

* The reset button (#treeFilterReset) in the page tree filter box is repositioned (little to the right, little to the bottom) to be centered
* The filtering JS is only included when the page browser hasFilterBox
* The tree filter input field (#treeFilter) is shortened by some pixels — there should be a some space between the reset button and long input (please see attached screenshots)
* The treeFilterReset does not require an additional fadeOut due to the fadeOut on parent div (#treeFilterBox)

* The filter input and filter is reset when the filter-icon is clicked

I guess this is the optimal behavior.


Tested on Safari 4, Firefox 3.6, Internet Explorer 7.


Looking forward to seeing this patch in the core soon :)

Warm regards from Hamburg,
Felix*




..............................

TYPO3 aus Hamburg.
Certified TYPO3 Integrator

TYPO3 Association Supporting Member

------------------------------



On 30.07.2010, at 16:46, Steffen Kamper wrote:

> Hi Felix,
> 
> Felix Kopp — PHORAX schrieb:
>> Hi Steffen-K,
>> actually I don't think so, otherwise all fly-out menus in the top bar had to act that same way.
>> 
> 
> i have a different opinion.
> 
>> Then on closing any fly-out the contained content should be reset.
>> (a) Open / Recent documents
>> (b) Shortcuts
>> (c) Search record
> 
> no. The fly-out menus behave wrong - they are normal menus and shouldn't stay open when mose leaves. This will change when they are replaced by real menus.
> 
>> I personally think that the current behavior is good.
>> User's should be able to hide the filter-fly-out to minimize visual noise without quitting the function.
>> 
> 
> this behaviour would be ok if the display is inside the collapsing panel, but here you see the pagetree filtered. Collapse for having more space is no argument, space doesn't change, so why should you collapse?
> 
> So imho we have 2 possibilities:
> 1) reset the filter but leave the input filled, on next open you might use it again
> 2) reset the filter and reset the input
> 
> vg Steffen
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100813/90fd1795/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15294-v2.diff
Type: application/octet-stream
Size: 1653 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100813/90fd1795/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100813/90fd1795/attachment-0003.htm>