[TYPO3-core] RFC #15395: Code cleanup for t3lib_compressor

Xavier Perseguers typo3 at perseguers.ch
Tue Aug 10 16:47:45 CEST 2010


Hi,

>> It's great to see some action from your side Bernhard. Not to offend
>> you, but that is the second time you committed without enough reviews.
>> (there was just one +1 on reading from me, nothing more).
>
> Ähm. Steffen who posted the patch is a core team member, you are and
> gave a +1, and also a +1 from my side is enough I think.

Well, there was a +1 by _reading_, not by _testing_ and you did not 
write that you gave a +1 by reading and testing, you just said you 
committed... Meaning:

- You should tell us explicitly that you gave the +1 by reading and testing
- A +1 by testing by _anybody_ was missing anyway

Cheers
Xavier


More information about the TYPO3-team-core mailing list