[TYPO3-core] RFC: #15280: felogin redirect doesn't work anymore after update to latest releases (4.2x - 4.4.x)

Helmut Hummel helmut at typo3.org
Thu Aug 5 00:07:15 CEST 2010


Hi,

On 04.08.10 10:16, Ernesto Baschny [cron IT] wrote:
> Helmut Hummel schrieb am 04.08.2010 09:31:
>>
>> So I will provide a new patch along with unit tests somewhen this evening.
> 
> Looking forward to it, thanks a lot for the work on that, Helmut!

OK.

Find attached a new version of the patch along with some unit test,
which (I hope) cover all to be expected cases.

Two things:

1. I added a check, if the following chars "<>\ are in an URL it is
considered invalid. I someone expects problems with that, I'm also fine
removing this again, since the url is escaped before put in the HTML,
this is just a defense in depth aproach.

2. Two tests which consider that URLs with special chars shoud work fail
currently, because of filter_validate does not consider this a valid
URL. I'm totally fine not allowing such chars in a URL, but since Olly
made some efforts to support them for the backend, I'm not sure.

Besides that, it works now as I would expect it.

Feedback appreciated.

Regards Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015280_v7.patch
Type: text/x-patch
Size: 15779 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100805/d0b24227/attachment.bin>


More information about the TYPO3-team-core mailing list