[TYPO3-core] RFC #15338: sys_action: Link to edit the sql query action is missing for newly created actions
Stefan Galinski
sgalinski at df.eu
Tue Aug 3 17:11:02 CEST 2010
Jeff Segars wrote:
> +1 on reading and testing.
>
> Two little CGL nitpicks can be addressed at commit
> * For the if statement in the first hunk, move the closing parenthesis
> up a line
> * In the second hunk, remove the whitespace after 'xml'
Hi Jeff,
Thanks for your review. Attached is the second version that fixes your
mentioned issues.
I just want to note that the "if" clause is really ugly to read if the
closing parenthesis are moved to the end instead of a new line, but I
respect the cgl.
--
Stefan Galinski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15338_v2.diff
Type: text/x-patch
Size: 1807 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100803/e8a20167/attachment.bin>
More information about the TYPO3-team-core
mailing list