[TYPO3-core] RFC #15338: sys_action: Link to edit the sql query action is missing for newly created actions

Jeff Segars jsegars at alumni.rice.edu
Tue Aug 3 16:56:52 CEST 2010


On 8/3/10 9:17 AM, Stefan Galinski wrote:
> This is a SVN patch request.
>
> Type: Bugfix
>
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=15338
>
> Branches: trunk, 4.4
>
> Problem:
> The link to edit the sql query is missing for newly created actions. This
> causes big headaches, because you must know that the sql query needs to be
> edited with the "Admin Tool ->  DB Check ->  Full Search ->  Advanced Query"
> tool.
>
> Solution:
> Change the "wrong configuration" check to let empty sql query requests pass.
>
> How to Test:
> - Install the extensions taskcenter and sys_actions
> - Create a new action of type "SQL query" (User Tool->  Task Center ->  Click
> on the header of the second block)
> - Call the newly created action with and without the patch
>

+1 on reading and testing.

Two little CGL nitpicks can be addressed at commit
* For the if statement in the first hunk, move the closing parenthesis 
up a line
* In the second hunk, remove the whitespace after 'xml'

Thanks!
Jeff


More information about the TYPO3-team-core mailing list