[TYPO3-core] RFC #14195: Reorganize the backend stylesheets

[François Suter]

Hi,

What a beast to review ;-)

> Solution:
> * Remove all (not absolutely needed) CSS from core
> * Add the now missing CSS to t3skin
> * Restructure the CSS files and separate between structure definitions
> (height, width, position, etc.) and visual styles (color, border, …)

I'm globally positive. I have just a few small remarks below, after 
which I will gladly give my +1 after reading and testing.

- you removed this whole line from NEWS.txt:

"It is now possible to add whole directories of CSS files to the backend 
by setting $TBE_STYLES['stylesheetDirectories'][$_EXTKEY][] = 
'EXT:myext/stylesheets/'"

but shouldn't it be rather changed to indicate the new syntax, like:

"It is now possible to add whole directories of CSS files to the backend 
by setting $TBE_STYLES['skin'][$_EXTKEY]['stylesheetDirectories'] = 
'EXT:myext/stylesheets/'"

?

- I now have a small shift in the alignment of group fields in various 
configurations, see attached screenshots. This is minor compared to this 
whole patch and could be corrected afterward, but I don't want this to 
be forgotten.

- also I discussed with Fabien (who was sitting next to me) the issue 
with the stylesheets being loaded in alphabetical order, which seems a 
bit arbitrary. Fabien said that you meant that this didn't have an 
impact. It still seems a bit dangerous if some CSS file does some resets 
and happens in the middle of all the files. However I still like the 
fact that there's no need to define a loading order explicitly, so maybe 
we could have a convention that a file that must come first should have 
a name starting with "__" or "00". This could be written down in the 
upcoming Core Skinning manual.

Cheers

François Suter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: group_field_offset.png
Type: image/png
Size: 24964 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/68259041/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: group_field_offset_2.png
Type: image/png
Size: 10604 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/68259041/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: group_field_offset_3.png
Type: image/png
Size: 18356 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/68259041/attachment-0005.png>