[TYPO3-core] RFC: #14201: getBrowserInfo delivers wrong info

Steffen Kamper info at sk-typo3.de
Tue Apr 27 22:21:24 CEST 2010


Hi Lars,

Lars Houmark schrieb:
> Hi Steffen,
> 
> Steffen Kamper wrote:
> 
>> Type: bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=14201
>>
>> Branches:
>> trunk, 4_3
> 
> +1 on reading and testing on both trunk and 4_3 branch with the 
> following browsers:
> 

thx!

> One minor nitpick. Using chrome the 'browser' value is returned as 
> 'Safari' which is technically correct, and as discussed in private, this 
> can change by Chrome changing the order they print the browser info in 
> the 'useragent' string.
> 
> For 4.5 there should be an improved TypoScript that works something like:
> 
> [browser has chrome]
> 
> But for improving the current values, this is already a very nice 
> improvement. And it is still possible to get the chrome value by moving 
> into the 'all' array of the browser info data.
>

i have a solution in mind which can be used without a new feature. I 
will post a new RFC in some minutes.


> Also I agree that there is no need for being especially caring about 
> backwards-compatibility about the change from 'netscape' in most 
> browsers currently, to the now correct value, as it can be expected that 
> no-one was relying on that value up until now.
> 
> Another small nitpick which can be corrected on commit. You are using 
> count() (on line 53 of the patch) inside the for loop which is against CGL.
>

i think you mix it with using count in loops ;)


> Nice work. Next up is the devices part :)
> 

:) will do next.

vg Steffen


More information about the TYPO3-team-core mailing list