[TYPO3-core] RFC: #14201: getBrowserInfo delivers wrong info

[Lars Houmark]

Hi Steffen,

Steffen Kamper wrote:

> Type: bugfix
>
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=14201
>
> Branches:
> trunk, 4_3

+1 on reading and testing on both trunk and 4_3 branch with the 
following browsers:

- Chrome/5.0.375.17 on Mac OS X 10.6.3
- Safari 4.0.5 on Mac OS X 10.6.3
- Firefox/3.6.3 on Mac OS X 10.6.3
- Opera 10.52 on Mac OS X 10.6.3
- Firefox 3.5.9 on Ubuntu 9.10
- Chrome/5.0.342.9 on Ubuntu 9.10
- IE8 (8.0.6001.18702) on Windows XP
- IE7 (7.0.5730.13) on Windows XP
- IE6 (6.0.2900.2180.xpsp_sp2_qfe.091208-2052) on Windows XP
- Chrome/4.1.249.1045 on Windows XP
- Firefox/3.6.3 on Windows XP
- Firefox/3.5 on Windows XP
- Firefox/2.0.0.20 on Windows XP

One minor nitpick. Using chrome the 'browser' value is returned as 
'Safari' which is technically correct, and as discussed in private, this 
can change by Chrome changing the order they print the browser info in 
the 'useragent' string.

For 4.5 there should be an improved TypoScript that works something like:

[browser has chrome]

But for improving the current values, this is already a very nice 
improvement. And it is still possible to get the chrome value by moving 
into the 'all' array of the browser info data.

Also I agree that there is no need for being especially caring about 
backwards-compatibility about the change from 'netscape' in most 
browsers currently, to the now correct value, as it can be expected that 
no-one was relying on that value up until now.

Another small nitpick which can be corrected on commit. You are using 
count() (on line 53 of the patch) inside the for loop which is against CGL.

Nice work. Next up is the devices part :)

-- 
Lars Houmark