[TYPO3-core] RFC #14028: Code cleanup: Cleanup: class.t3lib_userauthgroup.php

Dmitry Dulepov dmitry.dulepov at gmail.com
Wed Apr 21 10:35:09 CEST 2010


Hi!

Kjeld Schumacher wrote:
> ok, I splitted them in three parts, see attachments. I hope I did not
> missed something.

I got a small change in the variables patch: we try to return the value
only once in the function, so I fixed that and refactored variuable names
even more inside isPSet() function.

Patches get my +1 by reading (variables patch also by testing).

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14028_variables_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100421/23ae8e3f/attachment.txt>


More information about the TYPO3-team-core mailing list