[TYPO3-core] RFC #14028: Code cleanup: Cleanup: class.t3lib_userauthgroup.php

Kjeld Schumacher ks at not-only-pixel.de
Wed Apr 7 18:02:48 CEST 2010


On 04/07/2010 04:45 PM, Oliver Klee wrote:
> Hi,
>
> Kjeld Schumacher schrieb:
>    
>> Notes:
>> Is this patch ok? Or should i split them in three parts and open for
>> each issue a new bugtracker entry?
>>      
> I'd prefer three separate patches for review (one for formatting, one
> for foreach, and one for the variable names).
>
> This makes reviewing easier because I know what to look for in each patch.
>
>
> Oli
>    
ok, I splitted them in three parts, see attachments. I hope I did not 
missed something.

-- 
Kjeld Schumacher
__________________________________________________
Programmierer
not-only-pixel.de

tel: (030) 60 40 91 59
mobil: (0179) 79 53 101
mail: ks at not-only-pixel.de
web: http://not-only-pixel.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14028_variables.diff
Type: text/x-diff
Size: 2163 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100407/4c8af316/attachment-0003.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14028_CGL.diff
Type: text/x-diff
Size: 64374 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100407/4c8af316/attachment-0004.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14028_foreach.diff
Type: text/x-diff
Size: 640 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100407/4c8af316/attachment-0005.diff>


More information about the TYPO3-team-core mailing list