[TYPO3-core] RFC: Bug #13972: cropHTML uses faulty reg exp for HTML entities

Ralf Hettinger ng at ralfhettinger.de
Fri Apr 16 23:32:08 CEST 2010


Hi Jigal & Jochen.

Am 16.04.2010 16:38 schrieb Jochen Rau:
[...]
> A suggestion how to proceed here: The main part of the reported issue in
> cropHTML is resolved by the patch Ralf provided ("the current preg_match
> currently always crops after the first semicolon"). The second part
> isn't ("... and won't recognize entites reliably"). I'd like to move the
> second part into another issue and vote only for the first. In this case
> I'd vote +1 by reading and testing.
> 
> If we don't slice this into different junks, another improvement of
> TYPO3 will be lost in the endless stream of the mailing list ...

I fully agree, thanks for the suggestion. Although the quantifier in the
pattern should be &[^&\s;]{2,8}; as mentioned previously. Patch is attached.

Cheers Ralf
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: issue_13972_v4.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100416/70755c38/attachment.txt>


More information about the TYPO3-team-core mailing list