[TYPO3-core] RFC #13998: Introduce Automatic versioning of CSS and JS files

[Oliver Klee]

Hi,

Ernesto Baschny [cron IT] schrieb:
> I changed some longer lines and slightly fixed the text of the
> FE-setting. Attached is _v8 which I just commited to trunk (rev. 7346).

...

> all the testLoad<Framework> will now probably fail with the latest
> addition (RFC#13998) which adds "?<timestamp>" to all rendered
> javascript filenames (or in the filename, depending on the new setting).
> 
> So all those tests would need to be adapted:
> 
> In stead of this:
>   contrib/prototype/prototype.js
> 
> if could also be this:
>   contrib/prototype/prototype.js?1234656
> 
> or this:
>   contrib/prototype/prototype.123456.js
> 
> Maybe checking with a regexp (blabla...prototype\.(js|js?\d+|\d\.js)) ?

Indeed.

<rant>
People, don't you run the unit tests when you change things to make sure
you don't break anything? That's what the tests are for.

I find this really annoying. Usually, the person writing a patch (or the
person checking in a patch) should make sure that the patch doesn't
break any tests, and if it does, fix the patch (or modify the tests).
And if a checkin breaks the tests, it's their responsibility to fix the
tests as soon as possible sp a "green bar" means "I can use the tests to
test that my changes don't break anything" again.
</rant>

Anyway:

The environment in which the tests are run are usually quite
well-defined. So a (maybe simpler) regexp should do the trick.

Ernesto, Lars, will you take care of this?

Thanks,


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member