[TYPO3-core] RFC: Bug 5678: Missing clearer div in csc-textpic-intext-left/csc-textpic-intext-right

Ernesto Baschny [cron IT] ernst at cron-it.de
Tue Apr 13 21:20:06 CEST 2010


Hi,

it works, and +1 by testing.

Missing are the notes in the upgrade wizard about the CSS changes when
upgrading to 4.4 (adding "v4.3" to
sysext/install/updates/class.tx_coreupdates_cscsplit.php and documenting
the change of behaviour in sysext/css_styled_content/ext_localconf.php).

I also +1 on Joeys opinion that we don't want to introduce more
CSS-hacks in frontend output in TYPO3.

Nonetheless I find it ugly that we have to copy the whole static
template of v4.3 just because of this tiny change. I would have
preferred to continue with just one setup.txt and conditions.

If we did that, these lines would suffice:

styles.content.imgtext.addIntextClearer = 0
[compatVersion = 4.4.0]
styles.content.imgtext.addIntextClearer = 1
[global]

But alas, it is how it is now.

Cheers,
Ernesto

Susanne Moog schrieb am 13.04.2010 20:34:
> On 03.06.2007 14:59, Oliver Hader wrote:
>> This is a SVN patch request.
>>
>> Problem:
>> When placing two (or more) content elements of the type "text w/image"
>> (with "intext-left" or "intext-right" for the image positioning)
>> underneath each other and the text does not reach beneath the lower
>> picture border, then the picture of the second content element is
>> positioned on the side of the upper picture instead of underneath. The
>> content elements are "crammed" into each other.
>>
>> Solution:
>> Add a clearer div (<div class="csc-textpic-clear">) to the end of this
>> content elements to prevent the "wild" floating.
> 
> As discussed with Steffen via Skype find attached a new version of this
> patch. The functional part is the one with the actual changes, the
> structure part is the one that adds the compatibility layer for 4.3.
> 
> Please, before you vote have a look at the current setup.txt file and
> the surrounding lines
> 
> <snip>
> default = TEXT
> default.value = <div class="csc-textpic csc-textpic-center
> csc-textpic-above###CLASSES###">###IMAGES######TEXT###</div><div
> class="csc-textpic-clear"><!-- --></div>
> # above-right
> 1 = TEXT
> 1.value = <div class="csc-textpic csc-textpic-right
> csc-textpic-above###CLASSES###">###IMAGES######TEXT###</div><div
> class="csc-textpic-clear"><!-- --></div>
> # above-left
> 2 = TEXT
> 2.value = <div class="csc-textpic csc-textpic-left
> csc-textpic-above###CLASSES###">###IMAGES######TEXT###</div><div
> class="csc-textpic-clear"><!-- --></div>
> # below-center
> 8 = TEXT
> 8.value = <div class="csc-textpic csc-textpic-center
> csc-textpic-below###CLASSES###">###TEXT######IMAGES###</div><div
> class="csc-textpic-clear"><!-- --></div>
> # below-right
> 9 = TEXT
> 9.value = <div class="csc-textpic csc-textpic-right
> csc-textpic-below###CLASSES###">###TEXT######IMAGES###</div><div
> class="csc-textpic-clear"><!-- --></div>
> # below-left
> 10 = TEXT
> 10.value = <div class="csc-textpic csc-textpic-left
> csc-textpic-below###CLASSES###">###TEXT######IMAGES###</div><div
> class="csc-textpic-clear"><!-- --></div>
> </snip>
> 
> The clear divs are currently everywhere, only missing at the two places
> I add them to. So with this patch all we'll do is make it consistent. We
> can discuss another solution (CSS based or however) in the content
> rendering list, but then for all cases, not just the two this patch is
> about.
> 
> Best regards,
> 
> Susanne
> 


More information about the TYPO3-team-core mailing list