[TYPO3-core] RFC: #13698: Add proxy for the mail() function

[Tolleiv.Nietsch]

Hi,
v4 attached.

Am 13.04.2010 19:27, schrieb Oliver Klee:
> - please use camelCase for the variable names:
>    $additional_headers ->  $additionalHeaders
>    $additional_parameters ->  $additionalParameters

changed it in the patch - but: as I wrote I copied the API of mail() and 
therefore I found it more convenient to have the same variable names. 
But of course we're in TYPO3 so this part has to fit our CGL.

> - please use strings ('') as default for the two string parameters
> $additional_headers and $additional_parameters, not null

I didn't do that because I've no glue whether mail behaves different if 
you pass '' instead of null. What I see on php.net I don't think that 
this would matter but I'm sure that null is "safer" than ''.

> - I'd prefer the variable name $messageBody instead of $message

see a$dditional_headers - done but don't really like it...

> - $fakeThis always is FALSE an will not be changed. Is there any reason
> why we have this parameter at all? I suggest to just remove it.

t3lib_div::callUserFunction() expects to get a reference as 3rd 
parameter - you'd have to change to API to get rid of that.

Cheers,
Tolleiv
-- 
Tolleiv Nietsch
www.tolleiv.de - www.aoemedia.de
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sendMail_v4.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100413/561f9e50/attachment.asc>