[TYPO3-core] RFC #12066: Code cleanup: Add some constants

[Oliver Klee]

Hi,

thanks for the two new reviews.

By the way, the original patch already had enough +1 for committing it -
this was just an update of the patches to the current trunk and a
reminder for Benni who has promised to check them in. :-)

Still, thanks for the reviews. More eyes on a patch always are a good thing.

Kjeld Schumacher schrieb:
> But, i found one mistake.
> In the patch, search for
> "typo3/sysext/lowlevel/clmods/class.cleanflexform.php" and on line 180,3
> there is one line deleted but i can not find the new insert line. Did I
> missed something there?

I that file, I see only four changed lines, but no line that was just
deleted:

Index: typo3/sysext/lowlevel/clmods/class.cleanflexform.php
===================================================================
--- typo3/sysext/lowlevel/clmods/class.cleanflexform.php	(revision 7304)
+++ typo3/sysext/lowlevel/clmods/class.cleanflexform.php	(working copy)
@@ -91,7 +91,7 @@

 			// Initialize result array:
 		$resultArray = array(
-			'message' =>
$this->cli_help['name'].chr(10).chr(10).$this->cli_help['description'],
+			'message' =>
$this->cli_help['name'].LF.LF.$this->cli_help['description'],
 			'headers' => array(
 				'dirty' => array('','',2),
 			),
@@ -125,7 +125,7 @@
 		t3lib_div::loadTCA($tableName);
 		foreach($GLOBALS['TCA'][$tableName]['columns'] as $colName => $config)	{
 			if ($config['config']['type']=='flex')	{
-				if ($echoLevel>2)	echo chr(10).'			[cleanflexform:] Field
"'.$colName.'" in '.$tableName.':'.$uid.' was a flexform and...';
+				if ($echoLevel>2)	echo LF.'			[cleanflexform:] Field "'.$colName.'"
in '.$tableName.':'.$uid.' was a flexform and...';

 				$recRow = t3lib_BEfunc::getRecordRaw($tableName,'uid='.intval($uid));
 				$flexObj = t3lib_div::makeInstance('t3lib_flexformtools');
@@ -180,10 +180,10 @@

 					// Return errors if any:
 				if (count($tce->errorLog))	{
-					echo '	ERROR from
"TCEmain":'.chr(10).'TCEmain:'.implode(chr(10).'TCEmain:',$tce->errorLog);
+					echo '	ERROR from
"TCEmain":'.LF.'TCEmain:'.implode(LF.'TCEmain:',$tce->errorLog);
 				} else echo 'DONE';
 			}
-			echo chr(10);
+			echo LF;
 		}
 	}
 }


Or have I misunderstood you?

All the best,


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member