[TYPO3-core] RFC: #13952: Hookrequest - t3lib_page::getPageOverlay

Andreas Otto andreas at otto-hanika.de
Sun Apr 11 14:22:27 CEST 2010


Hi Steffen,

Am Samstag, den 10.04.2010, 23:02 +0200 schrieb Steffen Kamper: 
> Hi,
> 
> FYI: committed to trunk rev 7273
> 
> vg Steffen

Looks like you committed about 5 hours too early ;-)


Regarding the recent commits of new hooks I have a few questions.

How do we decide when to commit new hooks? If my maths are right there
were 2 +1 by reading which is usualy not enough for a commit, right?

On the other hand you could classify these hooks as no-brainers which
would allow for instant commit.

Testing hooks without proper testcases or steps to reproduce will always
lead to "+1 by reading" I guess.


Cheers,
Andreas




More information about the TYPO3-team-core mailing list