[TYPO3-core] RFC #13998: Introduce Automatic versioning of CSS and JS files

[Ernesto Baschny [cron IT]]

Stefano Kowalke schrieb am 09.04.2010 10:00:
> Hi Lars,
> 
>>> - CGL: comments are intended one addtional tab
>> In t3liv_div, the function above is using same indention, which is one tab and one space afterwards. Is this wrong? 
> 
> If someone touch exist code or write new code for an bugfix or feature
> he must follow the CGL. So t3lib_div is no good example for following
> the CGL ;-)
> 
> To have a first fast overview, please setup your mail client that
> attached files displayed inline.
> 
> 
> Some CGL nitpicking (line numbers are patch v5 related):
> 
> Line 9 and 17:
> Inline comments schould go one line above with one more intention.
> 	// Boolean. If true, ...
> 'versionNumberInFilename' => FALSE,

config_default.php is parsed by the install too ("All configuration"),
so it needs to be that exact syntax.

> Line 43: Spaces before and after the concatenation dot
> Line 69: Space before the concatenation dot
> Line 210: Spaces before and after the assignment operator
> Line 210: Space before the first concatenation dot
> Line 210: Spaces before and after the second concatenation dot
> Line 223: Space before the first concatenation dot
> Line 223: Spaces before and after the second concatenation dot
> Line 236 and 245: Space before the assignment operator (.=)

Please review by _v6. Apart from the CGL nitpicking, I also expect some
functional review or test.

Cheers,
Ernesto