[TYPO3-core] RFC #13998: Introduce Automatic versioning of CSS and JS files

Stefano Kowalke blueduck at gmx.net
Fri Apr 9 10:00:27 CEST 2010


Hi Lars,

> 
>> - CGL: comments are intended one addtional tab
> 
> In t3liv_div, the function above is using same indention, which is one tab and one space afterwards. Is this wrong? 

If someone touch exist code or write new code for an bugfix or feature
he must follow the CGL. So t3lib_div is no good example for following
the CGL ;-)

To have a first fast overview, please setup your mail client that
attached files displayed inline.


Some CGL nitpicking (line numbers are patch v5 related):

Line 9 and 17:
Inline comments schould go one line above with one more intention.
	// Boolean. If true, ...
'versionNumberInFilename' => FALSE,

Line 43: Spaces before and after the concatenation dot
Line 69: Space before the concatenation dot
Line 210: Spaces before and after the assignment operator
Line 210: Space before the first concatenation dot
Line 210: Spaces before and after the second concatenation dot
Line 223: Space before the first concatenation dot
Line 223: Spaces before and after the second concatenation dot
Line 236 and 245: Space before the assignment operator (.=)


Stefano


More information about the TYPO3-team-core mailing list