[TYPO3-core] RFC #12470: PHP-5.3 error: function define_syslog_variables() is deprecated

[Susanne Moog]

Hi,

On 06.04.2010 23:14, Jeff Segars wrote:
> On 11/4/09 3:40 PM, Rupert Germann wrote:
>> this is a SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=12470
>>
>> Branches: Trunk
>>
>> Problem:
>> when something is written to t3lib_div::syslog() the following warning
>> is displayed:
>> Deprecated: Function define_syslog_variables() is deprecated in
>> C:\xampp\xampp\htdocs\typo3\dummy-4.2.9\t3lib\class.t3lib_div.php on
>> line 5392
>>
>> when this error happens in the exception handler the output shows only:
>> Fatal error: Exception thrown without a stack frame in Unknown on line 0
>> the uncaught PHP message seems to break the exception handler.
>>
>> Solution:
>> remove the function call to define_syslog_variables().
>>
>> Background:
>> define_syslog_variables() initializes all (global) syslog variables. The
>> values are taken from constants which are always loaded. In the core
>> only the Constants are used, so it's save to simply remove this call.
>>
>>
>> greets
>> rupert
> 
> +1 on testing following Susanne's suggestions.
> 
> I don't have a working sysLog environment on PHP 5.3 to be 100% sure
> that everything is working the same as before, but Rupi's explanation of
> why define_syslog_variables() is not needed makes sense so there should
> be no changed behavior.

thanks, so this one is ready to be committed.

Best regards,

Susanne