[TYPO3-core] RFC: #10327: [felogin] redirecting to referer does not work

[Xavier Perseguers]

Hi,

Steffen may reply to Susanne question perhaps?

Anyway, REMINDER #3 for the patch.

On 03/27/10 8:46 , Susanne Moog wrote:
> Hi,
>
> Xavier Perseguers wrote:
>> Hi,
>>
>> Please find enclosed a follow-up for this bug (committed as revision
>> 6638). Lines around 468 that were added do not allow redirect_url to be
>> defined when a user is not yet logged in ($this->logintype==='login'),
>> and as such modifying line 477 should not have happened.
>>
>
> works but the question is, if the part above is now really needed:
>
> if (!$gpRedirectUrl&&  $this->redirectUrl&&  $this->logintype === 'login') {
> 	$gpRedirectUrl = $this->redirectUrl;
> }
>
> ...
> $markerArray['###REDIRECT_URL###'] = $gpRedirectUrl ?
> htmlspecialchars($gpRedirectUrl) : htmlspecialchars($this->redirectUrl);
>
>
> Can you explain why we need the "$this->logintype === 'login'"
> comparison? Could we not just kill that comparison?
>
> if (!$gpRedirectUrl&&  $this->redirectUrl) {
> 	$gpRedirectUrl = $this->redirectUrl;
> }
>
>
> Best regards,
>
> Susanne


-- 
Xavier Perseguers
http://xavier.perseguers.ch/en