[TYPO3-core] RFC #13487: bugfix: no alternative icon returned from 'getIcon' in class.t3lib_iconworks.php (backend-redesign)

[Susanne Moog]

Hi Stephan,

On 04.04.2010 23:22, Stephan N Kellermayr wrote:
> hello Susanne,
> 
> i am sorry, but i think its not so easy to test, because if you do not
> use an extension which adds new icons (or even new icon-states), you
> will not see any "bug".
> 
> i think the easiest way is:
> install t3xskin and use the patch i have added here as attachement.
> its the same modification which you can find as patch-file provided by
> t3xskin, but i kept the concerning line from source.
> 
> if you then edit a normal page and activate checkbox 'Hide Page' AND
> 'Hide in Menu' you should see that the generated filename is something
> like 'pages__hn.gif'.
> this filename has added an additional state at the and, the
> 'n'-appendix, and this file does not exist as image in the source.
> 
> the result is, that the shown file is a temporary generated image with a
> red 'X' on it, or, if you have activated the option
> $TYPO3_CONF_VARS['GFX']['noIconProc'] in localconf.php, an icon with a
> red questionmark and the filename 'pages__x.gif'.
> 
> and thats the point of this issue: if an extension provides icons which
> are not available in the source (and remember: the default iconset is
> NOT complete), the alternative icon will not be visible, because the
> alternative path is never checked.

thanks for the explanation and testing instructions.

+1 by reading and testing.

BTW please add the missing spaces (CGL) around the concatenations.

Best regards,

Susanne