[TYPO3-core] RFC #11576: Feature/Bug - Colorpicker has no usable icon

Dmitry Dulepov dmitry.dulepov at gmail.com
Wed Sep 9 14:27:52 CEST 2009


Hi!

Stefan Geith wrote:
>> I added one png and one psd:
>> http://bugs.typo3.org/file_download.php?file_id=8287&type=bug
>> http://bugs.typo3.org/file_download.php?file_id=8288&type=bug
> 
> They look much better !
> 
> So I will change my patch to use
>   gfx/colorpicker_empty.png and gfx/colorpicker.png
> instead. OK ?
> 
> Should I include the PNG-files to the patch ?
> (I would use your PSD-File to generate them...)

I just attached yet another png for the default skin. The file for the default skin must go to gfx/, the file for t3skin must go to typo3/sysext/t3skin/icons/gfx/. Both files must have the same name.

> Should I use t3lib_iconWorks::skinImg to get the Icons like this:
> <snip>
>   $colorBoxLinks[0].'<img '.
>     t3lib_iconWorks::skinImg($this->backPath,
>       (strlen(trim($color))==0 || strcmp(trim($color),'0')==0) ?
> 'gfx/colorpicker_empty.png' : 'gfx/colorpicker.png',
>       'width="'.$dX.'"
> height="'.$dY.'"'.t3lib_BEfunc::titleAltAttrib(trim($iTitle.'
> '.$PA['itemFormElValue'])).' border="0"').
>   '>'.$colorBoxLinks[1].
> </snip>

Looks ok to the first quick glance.

-- 
Dmitry Dulepov
Facebook: http://www.facebook.com/dmitryd
Twitter: http://twitter.com/dmitryd
Skype: liels_bugs


More information about the TYPO3-team-core mailing list