[TYPO3-core] RFC #11576: Feature/Bug - Colorpicker has no usable icon

[Stefan Geith]

Dmitry Dulepov schrieb:
> Stefan Geith wrote:
>> I added some png-files to the Bugtracker, maybe they are better ?
> 
> Did you convert them from that existing gif? The still look a little dirty... 

No - from existing JPG ...

> I added one png and one psd:
> http://bugs.typo3.org/file_download.php?file_id=8287&type=bug
> http://bugs.typo3.org/file_download.php?file_id=8288&type=bug

They look much better !

So I will change my patch to use
   gfx/colorpicker_empty.png and gfx/colorpicker.png
instead. OK ?

Should I include the PNG-files to the patch ?
(I would use your PSD-File to generate them...)

Should I use t3lib_iconWorks::skinImg to get the Icons like this:
<snip>
   $colorBoxLinks[0].'<img '.
     t3lib_iconWorks::skinImg($this->backPath,
       (strlen(trim($color))==0 || strcmp(trim($color),'0')==0) ? 
'gfx/colorpicker_empty.png' : 'gfx/colorpicker.png',
       'width="'.$dX.'" 
height="'.$dY.'"'.t3lib_BEfunc::titleAltAttrib(trim($iTitle.' 
'.$PA['itemFormElValue'])).' border="0"').
   '>'.$colorBoxLinks[1].
</snip>



/Stefan