[TYPO3-core] RFC #11555: Feature: Scheduler

[Francois Suter]

Hi,

Thanks for the review.

> 1. Undefined variables:
> 
> mod1/index.php:
>   lines 191, 206, 214, 225:
>     undefined variable "$scheduler". This should probably be 
> "$this->scheduler"
> 
>   lines 787, 788:
>     undefined variable "$class".
> 
>   line 873:
>     undefined variable "$checked".
> 
>   line 1168:
>     undefined variable "$minute". Should be "$minutes"

I opened a bug report for this [1] and the issue is solved as of 
revision 1204.

> (A proper IDE like Zend Studio highlights those by the way)

Nice feature. I use NetBeans, which doesn't.

> 2. (tweak): The validation error message "Please insert a valid interval 
> (> 0)" is a bit misleading. It should contain the affected field 
> ("frequency" in this case) - I just realized, there's a bug report for 
> this already.

That is addressed too, see [2].

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch

[1] http://forge.typo3.org/issues/show/4481
[2] http://forge.typo3.org/issues/show/4474