[TYPO3-core] RFC #11555: Feature: Scheduler
Bastian Waidelich
bastian at typo3.org
Mon Sep 7 13:22:47 CEST 2009
Francois Suter wrote:
Hi Francois,
>> That's it, the Scheduler is ready for a final review.
Great work, the BE module looks neat!
Still -1 for now, cause:
1. Undefined variables:
mod1/index.php:
lines 191, 206, 214, 225:
undefined variable "$scheduler". This should probably be
"$this->scheduler"
lines 787, 788:
undefined variable "$class".
line 873:
undefined variable "$checked".
line 1168:
undefined variable "$minute". Should be "$minutes"
(A proper IDE like Zend Studio highlights those by the way)
2. (tweak): The validation error message "Please insert a valid interval
(> 0)" is a bit misleading. It should contain the affected field
("frequency" in this case) - I just realized, there's a bug report for
this already.
best,
Bastian
More information about the TYPO3-team-core
mailing list