[TYPO3-core] RFC #11773: Integrate an option to deactivate shortcuts completely
Christopher Stelmaszyk
christopher at yahoo.de
Wed Sep 2 17:24:45 CEST 2009
Hi Rupert,
first of all sorry for the long text, but it is needed here...
And I hope it is well structured.
"Rupert Germann" schrieb:
>
> I had a look to the patch and I have some remarks:
>
> now we have two options for hiding shortcuts:
> "enableShortcuts" and "shortcutFrame"
> for showing the shortcut-menu only "enableShortcuts" is needed.
I also introduced options.enableShortcuts in the old BE. So you can turn
shortcuts off separately (and not only with the workspace-selector etc.
together by disabling the whole shortcutFrame).
So to see the shortcut menu you will have to have enableShortcuts and
shortcutFrame set, because the shortcuts will be displayed in that frame.
What you say is correct for the new BE.
After all, the menu is displayed/hidden correctly in the old BE and in the
new one; here is no problem.
But it comes now...
> but for showing "create shortcut" buttons "enableShortcuts" and
> "shortcutFrame" has to be set.
I see, you are right. That is not correct. But somehow your proposed
solution - use a logical OR - also is not correct. ;-)
In the old BE the shortcuts are in the shortcutFrame.
So you must have set
shortcutFrame = 1 AND(!)
enableShortcuts = 1
to see the shortcuts you created. It does not make sense to be able to
create shortcuts which you then cannot see...
In the new BE, shortcuts are independent from shortcutFrame.
So there it is enough to have enableShortcuts = 1.
The value of shortcutFrame should not matter at all and should therefore not
be checked at all.
(But if we used your proposal, you would see the "create shortcuts" buttons
also if shortcutFrame = 1 and enableShortcuts = 0. That is wrong.)
So here is the solution:
We differentiate which version of the BE is used and set up the check
accordingly:
In the old BE, check if enableShortcuts AND shortcutFrame are set.
In the new BE, only check if enableShortcuts is set; do not check
shortcutFrame.
>
> And of course "shortcutFrame" has to be marked (documented) as deprecated.
Yes, tell the people that it only has an effect, if you set
auth.BE.redirectToURL = alt_main.php (maybe with parameters), that means if
you still use the old BE. And tell them, that there it will disable the
whole frame, that is the shortcut menu, the search and the workspace
selector.
Christopher
Index: typo3/classes/class.shortcutmenu.php
===================================================================
--- typo3/classes/class.shortcutmenu.php (revision 5881)
+++ typo3/classes/class.shortcutmenu.php (working copy)
@@ -99,8 +99,10 @@
* @return boolean true if user has access, false if not
*/
public function checkAccess() {
- // Shortcut module is enabled for everybody
- return true;
+ if ($GLOBALS['BE_USER']->getTSConfigVal('options.enableShortcuts')) {
+ return true;
+ }
+ return false;
}
/**
Index: t3lib/class.t3lib_userauthgroup.php
===================================================================
--- t3lib/class.t3lib_userauthgroup.php (revision 5881)
+++ t3lib/class.t3lib_userauthgroup.php (working copy)
@@ -656,7 +656,19 @@
* @return boolean
*/
function mayMakeShortcut() {
- return $this->getTSConfigVal('options.shortcutFrame') &&
!$this->getTSConfigVal('options.mayNotCreateEditShortcuts');
+ // If the old BE is used (maybe with some parameters),
+ // check for options.enableShortcuts and options.shortcutFrame being
set.
+ if (substr($this->getTSConfigVal('auth.BE.redirectToURL'), 0, 12) ==
'alt_main.php') {
+ return $this->getTSConfigVal('options.enableShortcuts') &&
+ $this->getTSConfigVal('options.shortcutFrame') &&
+ !$this->getTSConfigVal('options.mayNotCreateEditShortcuts');
+ }
+ // If the new BE is used, don't check options.shortcutFrame,
+ // because this is not used there anymore.
+ else {
+ return $this->getTSConfigVal('options.enableShortcuts') &&
+ !$this->getTSConfigVal('options.mayNotCreateEditShortcuts');
+ }
}
/**
Index: typo3/alt_shortcut.php
===================================================================
--- typo3/alt_shortcut.php (revision 5881)
+++ typo3/alt_shortcut.php (working copy)
@@ -426,8 +426,12 @@
-->
<table border="0" cellpadding="0" cellspacing="2"
id="typo3-shortcuts">
<tr>
- '.implode('
- ',$this->lines).$editIdCode.'
+ ';
+ if ($GLOBALS['BE_USER']->getTSConfigVal('options.enableShortcuts'))
{
+ $this->content .= implode('
+ ', $this->lines);
+ }
+ $this->content .= $editIdCode . '
</tr>
</table>
</td>
Index: t3lib/config_default.php
===================================================================
--- t3lib/config_default.php (revision 5881)
+++ t3lib/config_default.php (working copy)
@@ -203,7 +203,8 @@
'forceCharset' => '', // String. Normally the charset of the backend
users language selection is used. If you set this value to a charset found
in t3lib/csconvtbl/ (or "utf-8") the backend (and database) will ALWAYS use
this charset. Always use a lowercase value.
'installToolPassword' => '', // String. This is the md5-hashed password
for the Install Tool. Set this to '' and access will be totally denied.
PLEASE consider to externally password protect the typo3/install/ folder,
eg. with a .htaccess file.
'trackBeUser' => 0, // Boolean. If set, every invokation of a
backend script is logged in sys_trackbeuser. This is used to get a view of
the backend users behaviour. Mostly for debugging, support and user
interaction analysis. Requires 'beuser_tracking' extension.
- 'defaultUserTSconfig' => 'options.shortcutFrame=1', // String. Enter
lines of default backend user/group TSconfig.
+ 'defaultUserTSconfig' => 'options.shortcutFrame=1
+ options.enableShortcuts=1', // String. Enter lines of default backend
user/group TSconfig.
'defaultPageTSconfig' => '', // Enter lines of default Page TSconfig.
'defaultPermissions' => array ( // Default permissions set for new
pages in t3lib/tce_main.php. Keys are 'show,edit,delete,new,editcontent'.
Enter as comma-list
// 'user' => '', // default in tce_main is
'show,edit,delete,new,editcontent'. If this is set (uncomment), this value
is used instead.
begin 666 11773_enableShortcuts_v4.patch
M26YD97 at Z('1Y<&\S+V-L87-S97,O8VQA<W,N<VAO<G1C=71M96YU+G!H< T*
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/0T*+2TM('1Y<&\S+V-L87-S97,O8VQA
M<W,N<VAO<G1C=71M96YU+G!H< DH<F5V:7-I;VX at -3@X,2D-"BLK*R!T>7!O
M,R]C;&%S<V5S+V-L87-S+G-H;W)T8W5T;65N=2YP:' )*'=O<FMI;F<@8V]P
M>2D-"D! ("TY.2PX("LY.2PQ,"! 0 T*( D@*B! <F5T=7)N("!B;V]L96%N
M("!T<G5E(&EF('5S97(@:&%S(&%C8V5S<RP at 9F%L<V4@:68@;F]T"B )("HO
M"B )<'5B;&EC(&9U;F-T:6]N(&-H96-K06-C97-S*"D@>PHM"0D)+R\@4VAO
M<G1C=70@;6]D=6QE(&ES(&5N86)L960 at 9F]R(&5V97)Y8F]D>0HM"0ER971U
M<FX@=')U93L**PD):68@*"1'3$]"04Q36R="15]54T52)UTM/F=E=%130V]N
M9FEG5F%L*"=O<'1I;VYS+F5N86)L95-H;W)T8W5T<R<I*2!["BL)"0ER971U
M<FX@=')U93L**PD)?0HK"0ER971U<FX at 9F%L<V4["B )?0H@"B )+RHJ"DEN
M9&5X.B!T,VQI8B]C;&%S<RYT,VQI8E]U<V5R875T:&=R;W5P+G!H< T*/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/0T*+2TM('0S;&EB+V-L87-S+G0S;&EB7W5S
M97)A=71H9W)O=7 N<&AP"2AR979I<VEO;B U.#@Q*0T**RLK('0S;&EB+V-L
M87-S+G0S;&EB7W5S97)A=71H9W)O=7 N<&AP"2AW;W)K:6YG(&-O<'DI#0I
M0" M-C4V+#<@*S8U-BPQ.2! 0 T*( D@*B! <F5T=7)N"6)O;VQE86X*( D@
M*B\*( EF=6YC=&EO;B!M87E-86ME4VAO<G1C=70H*0E["BT)"7)E='5R;B D
M=&AI<RT^9V5T5%-#;VYF:6=686PH)V]P=&EO;G,N<VAO<G1C=71&<F%M92<I
M("8F("$D=&AI<RT^9V5T5%-#;VYF:6=686PH)V]P=&EO;G,N;6%Y3F]T0W)E
M871E161I=%-H;W)T8W5T<R<I.PHK"0D)+R\@268@=&AE(&]L9"!"12!I<R!U
M<V5D("AM87EB92!W:71H('-O;64@<&%R86UE=&5R<RDL"BL)"0DO+R!C:&5C
M:R!F;W(@;W!T:6]N<RYE;F%B;&53:&]R=&-U=', at 86YD(&]P=&EO;G,N<VAO
M<G1C=71&<F%M92!B96EN9R!S970N"BL)"6EF("AS=6)S='(H)'1H:7,M/F=E
M=%130V]N9FEG5F%L*"=A=71H+D)%+G)E9&ER96-T5&]54DPG*2P@,"P@,3(I
M(#T]("=A;'1?;6%I;BYP:' G*2!["BL)"0ER971U<FX@)'1H:7,M/F=E=%13
M0V]N9FEG5F%L*"=O<'1I;VYS+F5N86)L95-H;W)T8W5T<R<I("8F"BL)"0D)
M)'1H:7,M/F=E=%130V]N9FEG5F%L*"=O<'1I;VYS+G-H;W)T8W5T1G)A;64G
M*2 F)@HK"0D)"2$D=&AI<RT^9V5T5%-#;VYF:6=686PH)V]P=&EO;G,N;6%Y
M3F]T0W)E871E161I=%-H;W)T8W5T<R<I.PHK"0E]"BL)"0DO+R!)9B!T:&4@
M;F5W($)%(&ES('5S960L(&1O;B=T(&-H96-K(&]P=&EO;G,N<VAO<G1C=71&
M<F%M92P**PD)"2\O(&)E8V%U<V4@=&AI<R!I<R!N;W0@=7-E9"!T:&5R92!A
M;GEM;W)E+ at HK"0EE;'-E('L**PD)"7)E='5R;B D=&AI<RT^9V5T5%-#;VYF
M:6=686PH)V]P=&EO;G,N96YA8FQE4VAO<G1C=71S)RD@)B8**PD)"0DA)'1H
M:7,M/F=E=%130V]N9FEG5F%L*"=O<'1I;VYS+FUA>4YO=$-R96%T945D:713
M:&]R=&-U=',G*3L**PD)?0H@"7T*( H@"2\J*@I);F1E>#H@='EP;S,O86QT
M7W-H;W)T8W5T+G!H< T*/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/0T*+2TM('1Y
M<&\S+V%L=%]S:&]R=&-U="YP:' )*')E=FES:6]N(#4X.#$I#0HK*RL@='EP
M;S,O86QT7W-H;W)T8W5T+G!H< DH=V]R:VEN9R!C;W!Y*0T*0$ @+30R-BPX
M("LT,C8L,3(@0$ -"B )"0D)"0DM+3X*( D)"0D)"3QT86)L92!B;W)D97(]
M(C B(&-E;&QP861D:6YG/2(P(B!C96QL<W!A8VEN9STB,B(@:60](G1Y<&\S
M+7-H;W)T8W5T<R(^"B )"0D)"0D)/'1R/@HM"0D)"0D)"2<N:6UP;&]D92 at G
M"BT)"0D)"0D))RPD=&AI<RT^;&EN97,I+B1E9&ET261#;V1E+B<**PD)"0D)
M"0DG.PHK"0D)"0D)"6EF("@D1TQ/0D%,4ULG0D5?55-%4B==+3YG97144T-O
M;F9I9U9A;"@G;W!T:6]N<RYE;F%B;&53:&]R=&-U=',G*2D@>PHK"0D)"0D)
M"0DD=&AI<RT^8V]N=&5N=" N/2!I;7!L;V1E*"<**PD)"0D)"0D))RP@)'1H
M:7,M/FQI;F5S*3L**PD)"0D)"0E]"BL)"0D)"0D))'1H:7,M/F-O;G1E;G0@
M+CT@)&5D:71)9$-O9&4 at +B G"B )"0D)"0D)/"]T<CX*( D)"0D)"3PO=&%B
M;&4^"B )"0D)"3PO=&0^"DEN9&5X.B!T,VQI8B]C;VYF:6=?9&5F875L="YP
M:' -"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T-"BTM+2!T,VQI8B]C;VYF:6=?
M9&5F875L="YP:' )*')E=FES:6]N(#4X.#$I#0HK*RL@=#-L:6(O8V]N9FEG
M7V1E9F%U;'0N<&AP"2AW;W)K:6YG(&-O<'DI#0I 0" M,C S+#<@*S(P,RPX
M($! #0H@"0DG9F]R8V5#:&%R<V5T)R ]/B G)RP)"0D)"2\O(%-T<FEN9RX@
M3F]R;6%L;'D@=&AE(&-H87)S970@;V8@=&AE(&)A8VME;F0@=7-E<G,@;&%N
M9W5A9V4@<V5L96-T:6]N(&ES('5S960N($EF('EO=2!S970@=&AI<R!V86QU
M92!T;R!A(&-H87)S970 at 9F]U;F0@:6X@=#-L:6(O8W-C;VYV=&)L+R H;W(@
M(G5T9BTX(BD@=&AE(&)A8VME;F0@*&%N9"!D871A8F%S92D@=VEL;"!!3%=!
M65,@=7-E('1H:7, at 8VAA<G-E="X at 06QW87ES('5S92!A(&QO=V5R8V%S92!V
M86QU92X*( D))VEN<W1A;&Q4;V]L4&%S<W=O<F0G(#T^("<G+ D)"2\O(%-T
M<FEN9RX at 5&AI<R!I<R!T:&4@;60U+6AA<VAE9"!P87-S=V]R9"!F;W(@=&AE
M($EN<W1A;&P at 5&]O;"X at 4V5T('1H:7,@=&\@)R<@86YD(&%C8V5S<R!W:6QL
M(&)E('1O=&%L;'D at 9&5N:65D+B!03$5!4T4 at 8V]N<VED97(@=&\@97AT97)N
M86QL>2!P87-S=V]R9"!P<F]T96-T('1H92!T>7!O,R]I;G-T86QL+R!F;VQD
M97(L(&5G+B!W:71H(&$@+FAT86-C97-S(&9I;&4N"B )"2=T<F%C:T)E57-E
M<B<@/3X@,"P)"0D)"0DO+R!";V]L96%N+B!)9B!S970L(&5V97)Y(&EN=F]K
M871I;VX@;V8 at 82!B86-K96YD('-C<FEP="!I<R!L;V=G960@:6X@<WES7W1R
M86-K8F5U<V5R+B!4:&ES(&ES('5S960@=&\@9V5T(&$@=FEE=R!O9B!T:&4@
M8F%C:V5N9"!U<V5R<R!B96AA=FEO=7(N($UO<W1L>2!F;W(@9&5B=6=G:6YG
M+"!S=7!P;W)T(&%N9"!U<V5R(&EN=&5R86-T:6]N(&%N86QY<VES+B!297%U
M:7)E<R G8F5U<V5R7W1R86-K:6YG)R!E>'1E;G-I;VXN"BT@"0DG9&5F875L
M=%5S97)44V-O;F9I9R<@/3X@)V]P=&EO;G,N<VAO<G1C=71&<F%M93TQ)RP)
M"0DO+R!3=')I;F<N($5N=&5R(&QI;F5S(&]F(&1E9F%U;'0 at 8F%C:V5N9"!U
M<V5R+V=R;W5P(%138V]N9FEG+ at HK( D))V1E9F%U;'15<V5R5%-C;VYF:6<G
M(#T^("=O<'1I;VYS+G-H;W)T8W5T1G)A;64],0HK"0D);W!T:6]N<RYE;F%B
M;&53:&]R=&-U=',],2<L"0D)+R\@4W1R:6YG+B!%;G1E<B!L:6YE<R!O9B!D
M969A=6QT(&)A8VME;F0@=7-E<B]G<F]U<"!44V-O;F9I9RX*( D))V1E9F%U
M;'1086=E5%-C;VYF:6<G(#T^("<G+ D)"2\O($5N=&5R(&QI;F5S(&]F(&1E
M9F%U;'0 at 4&%G92!44V-O;F9I9RX*( D))V1E9F%U;'1097)M:7-S:6]N<R<@
M/3X at 87)R87D@* D)"2\O($1E9F%U;'0@<&5R;6ES<VEO;G,@<V5T(&9O<B!N
M97<@<&%G97,@:6X@=#-L:6(O=&-E7VUA:6XN<&AP+B!+97ES(&%R92 G<VAO
M=RQE9&ET+&1E;&5T92QN97<L961I=&-O;G1E;G0G+B!%;G1E<B!A<R!C;VUM
M82UL:7-T"B O+PD)"2=U<V5R)R ]/B G)RP)"0D)"0DO+R!D969A=6QT(&EN
M('1C95]M86EN(&ES("=S:&]W+&5D:70L9&5L971E+&YE=RQE9&ET8V]N=&5N
M="<N($EF('1H:7,@:7,@<V5T("AU;F-O;6UE;G0I+"!T:&ES('9A;'5E(&ES
/('5S960@:6YS=&5A9"X*
`
end
More information about the TYPO3-team-core
mailing list