[TYPO3-core] RFC: Bug #11831: Remove reference operators for objects

Oliver Hader oliver at typo3.org
Wed Sep 2 12:35:30 CEST 2009


Hi Steffen,

Steffen Kamper schrieb:
> Hi olly,
> 
> +1 by reading and testing.
> 
> 95% of replacements are simular ($pObj, $this, t3lib_div::getUserObj and
>  t3lib_div::makeInstance)
> 
> All the others are objects.
> 
> Only one is unclear by reading, the last one:
>      * @param    unknown_type        $ref
>       * @return    string        list item HTML attibutes
>       */
> -    public function updateNumberOfOpenDocsHook(&$params, &$ref) {
> +    public function updateNumberOfOpenDocsHook(&$params, $ref) {
> 
> as $ref is declared as "unknown_type" it'S not clear that's an object.

The hook is defined like this:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_befunc.php']['updateSignalHook']['tx_opendocs::updateNumber']
=
$opendocsPath.'class.tx_opendocs.php:tx_opendocs->updateNumberOfOpenDocsHook';

and is called in t3lib_BEfunc like this

$ref = NULL;
t3lib_div::callUserFunction($updateSignals[$set], $params, $ref);

Thus, everthing is fine with that part.
Thanks for your review!

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list