[TYPO3-core] RFC #10411: sqlparser is not able to parse more than 1 join

[Ernesto Baschny [cron IT]]

Hi Xavier,

I would love to have that in, but it is pretty difficult to guarantee
that such a change hasn't side effects because of the large amount of
not-documented regexps. So this is probably why you get so little
volunteers to give their "+1".

I guess it would be much easier to get changes to the SQL parser in if
we would have unit tests coverting all lines of code. That would make it
pretty easy to change / add stuff, without breaking other stuff.

Do you think it is possible that you could "kickstart" are least some
unit tests (maybe documenting your particular fix)?

Cheers,
Ernesto

Xavier Perseguers schrieb:
> Hi,
> 
> As I know that this change will certainly have some difficulty to get
> proper tested, may I ask some core dev to patch their trunk with it, and
> confirm after a few hours of "normal" behavior that trunk still works as
> before? It would make much sense to get this with beta2 to ensure proper
> "real" testing for DBAL-people around.
> 
> Cheers
> 
> Xavier Perseguers wrote:
>> Hi,
>>
>> This is a SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker reference:
>> http://bugs.typo3.org/view.php?id=10411
>>
>> Branches: trunk
>>
>> Problem:
>> While trying to fix a bug with mapping of table/field name in inner
>> join with DBAL, Michael Miousse found out that only 1 join (inner
>> join, left, ...) was supported by TYPO3 internal parser. Instead of
>> "fixing" this issue only in DBAL, I would like to get it in Core
>> instead because I don't want methods that are located in Core to be
>> copied and fixed in DBAL only.
>>
>> Solution:
>> Make the JOIN parsed configuration an array to allow more than one
>> instance to be supported.
>>
>> Regards
>>
> 
>