[TYPO3-core] RFC: #12175: User Setup don't check file time of ENABLE_INSTALL_TOOL

Martin Kutschker masi-no at spam-typo3.org
Sat Oct 10 14:39:26 CEST 2009


Steffen Kamper schrieb:
> Hi,
> 
> This is SVN patch request.
> 
> Type: Bugfix
> 
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=12175
> 
> As there is the option to delete/create this file in user setup, the
> displayed action in user setup is wrong:
> When the file is older than 1 hour, access to install tool is not
> possible. User setup only checks existence of the file and displayes
> "delete file". So you think all is ok anf go to install tool: No access
> there.
> 
> Solution: check file time too and delete if file is older than 1 hour.

You do not check the result of unlink() (and do not hide any warnings/errors it might display with
@) and $installToolEnableFileExists might be set to FALSE although the file still exists.

Masi


More information about the TYPO3-team-core mailing list