[TYPO3-core] RFC #11813: Code cleanup: refactoring t3lib_db to match CGLs

[Susanne Moog]

Hey,

+1 by reading with these remarks (referring to the lines in the patch):

l. 69 strict string comparison (before ==, now ===)
l. 77 + 82 probably missing brackets around the whole statement
l. 725 line length (121 chars) compare with 763/764
l. 785 missing space --> $this->debug('admin_query',$query);
l. 911 missing space --> t3lib_div::inList('ALL',$explain_output[0]['type'])

Best regards,

Susanne


Christian Kuhn schrieb:
> Hey,
> 
> Felix Oertel wrote:
>> sorry, missed one bracket ... and now patched against root.
> 
> +1 on reading and testing (everything seems to work like before).
> 
> Attached a new version with some minor things:
> - Another bracket
> - Some indentation changes
> - Some forgotten whitespaces and tab fixes
> 
> Good to get a better readable version of this class.
> 
> Thanks
> Christian
> 


-- 
Susanne Moog
NEUSTA GmbH - www.neusta.de