[TYPO3-core] RFC #12154: Improve flashmessages API

[Ernesto Baschny [cron IT]]

Rupert Germann schrieb:
> Bastian Waidelich schrieb:
>> FYI in the FLOW3 version we have a method for retrieving "getAll()"
>> and one for retrieving and flushing the messages "getAllAndFlush()":
>> http://forge.typo3.org/repositories/entry/package-flow3/trunk/Classes/MVC/Controller/FlashMessageContainer.php
>>
>> Maybe that is a bit more "explicit"!? (I didn't review the patch yet,
>> just an idea)
> 
> Although I already changed the function comment I like the idea of
> having more descriptive method names.
> 
> Since this API is brand new we still have the possibility to change it.
> 
> I would rename those two functions:
> t3lib_MessageQueue::getMessages() to getAllMessagesAndFlush()

+1

> and
> t3lib_FlashMessage::getStoreInSession() to isSessionMessage()

+1!

setStoreInSession => setAsSessionMessage (or something..)? Or keep it..

> something else that should be changed?

Maybe t3lib_MessageQueue -> t3lib_FlashMessageQueue?

Cheers,
Ernesto