[TYPO3-core] RFC #9683: Store OpenID information in database instead of using the filesystem

[Christian BELLET]

Hi,
Sorry for this mistake !

Christian

----- Message d'origine -----
De: Christian BELLET <chrisnt at gmail.com>
Env: samedi 28 novembre 2009 16:40
À: Dmitry Dulepov <dmitry.dulepov at gmail.com>; typo3-team-core at lists.typo3.org
Objet: Re: [TYPO3-core] RFC #9683: Store OpenID information in
database instead of using the filesystem


Envoyé depuis mon HTC HD2 d'Orange

----- Message d'origine -----
De: Dmitry Dulepov <dmitry.dulepov at gmail.com>
Env: samedi 28 novembre 2009 15:55
À: typo3-team-core at lists.typo3.org
Objet: Re: [TYPO3-core] RFC #9683: Store OpenID information in
database instead of using the filesystem


Hi!

On 27/11/2009 21:29, Steffen Kamper wrote:
> Some questions / minis:
> 1) as Ingmar already posted i also don't understand the comma in be_user
> and fe_user create queries:
> CREATE TABLE be_users (
> - tx_openid_openid varchar(255) DEFAULT '' NOT NULL
> + tx_openid_openid varchar(255) DEFAULT '' NOT NULL,
> );
>
> this looks wrong to me. Why did you add the comma?

This will be removed before the commit. It does not make any
difference to the TYPO3 actually.

> 2) also small issue, but i miss a sql_free_result.

Where?

> 3) often discussed and i thought we should use $GLOBALS['EXEC_TIME']
> instead time()

Generally yes but I did not want to rely on the variable, which can be
changed by somebody else.  Time is critical there, so I used the
function.

> Beside that the problems reported in this thread are not related to this
> RFC, so please give a comment on 1) that the patch can be committed for
> the final (with olly's ok)

If Olly says "yes", than I commit.

-- 
Dmitry Dulepov
"Trust me, I am a doctor!" (c) Gregory House, M.D.
_______________________________________________
Before posting to this list, please have a look to the posting rules
on the following websites:

http://typo3.org/teams/core/core-mailinglist-rules/
http://typo3.org/development/bug-fixing/diff-and-patch/
_______________________________________________
TYPO3-team-core mailing list
TYPO3-team-core at lists.typo3.org
http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
_______________________________________________
Before posting to this list, please have a look to the posting rules
on the following websites:

http://typo3.org/teams/core/core-mailinglist-rules/
http://typo3.org/development/bug-fixing/diff-and-patch/
_______________________________________________
TYPO3-team-core mailing list
TYPO3-team-core at lists.typo3.org
http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core