[TYPO3-core] RFC #9683: Store OpenID information in database instead of using the filesystem

[Dmitry Dulepov]

Hi!

On 27/11/2009 21:29, Steffen Kamper wrote:
> Some questions / minis:
> 1) as Ingmar already posted i also don't understand the comma in be_user
> and fe_user create queries:
> CREATE TABLE be_users (
> - tx_openid_openid varchar(255) DEFAULT '' NOT NULL
> + tx_openid_openid varchar(255) DEFAULT '' NOT NULL,
> );
>
> this looks wrong to me. Why did you add the comma?

This will be removed before the commit. It does not make any difference to the TYPO3 actually.

> 2) also small issue, but i miss a sql_free_result.

Where?

> 3) often discussed and i thought we should use $GLOBALS['EXEC_TIME']
> instead time()

Generally yes but I did not want to rely on the variable, which can be changed by somebody else.  Time is critical there, so I used the function.

> Beside that the problems reported in this thread are not related to this
> RFC, so please give a comment on 1) that the patch can be committed for
> the final (with olly's ok)

If Olly says "yes", than I commit.

-- 
Dmitry Dulepov
"Trust me, I am a doctor!" (c) Gregory House, M.D.