[TYPO3-core] FYI72: Fix bug #12623: Validation issues in sysext scheduler: Fix several errors

Ernesto Baschny [cron IT] ernst at cron-it.de
Fri Nov 20 18:20:17 CET 2009


Francois Suter schrieb:
>> Attached patch makes this and also adds several HSC to all tag
>> generating places (even on strings coming from LANG which are being used
>> in alt or title tags).
> 
> Isn't that overkill:
> 
> htmlspecialchars($GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.php:labels.reload',
> 1))
> 
> The second parameter in the call to sL() already triggers the use of
> HSC, so now it's called twice.
> 
> BTW I see that this parameter should use "TRUE" rather than 1 (my
> fault). Would you care to change that while you're at it?

You are right, haven't thought about the second parameter of sL().
Modified patch changes the HSC calls around sL() to a second parameter
of TRUE.

See attached _04 patch for the new variant.

Cheers,
Ernesto

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12623_04.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091120/3519bb4f/attachment-0001.txt>


More information about the TYPO3-team-core mailing list