[TYPO3-core] RFC: #11019: User Setup Rewrite #4

[Rupert Germann]

hi Steffen,

Steffen Kamper wrote:
> Now i'm really satisfied with the result, many thanks to Rupi for the
> review and constructive input.

well ..... we're getting there ;-)
I like the "showitems" thingy because the documentation for this was already
written to your mail: "Tabs are done exactly like in TCA with 
--div--;Label". That's it. Re-using already introduced priciples makes
sense!

But... 

I found some more quite serious issues and that make me really curious about
how you test your work. In this case you changed almost every code line
(aka rewrite) of a module that's able to change many aspects of the
BackEnd. So I'd expect that you test this "many aspects" before you publish
an RFC.

Here are some things that I tested:
* maxTitelLen doesn't work because the uc-key is called "titleLen" and
not "maxTitelLen"
* same goes for thumbnailsByDefault -> "showThumbs"
* same goes for language -> "lang" 
* htmlsource says: 
  <label for="field_LLL:EXT:setup/mod/locallang.xml:helpText"> ???
* RTEenabled and noMenuMode are always shown.
unset($fieldArray['noMenuMode']); fails of course, because there is no key
called 'noMenuMode' anymore.


some suggestions:
* the field "helpText" can be removed since it seems that its functionality
was replaced/merged with edit_showFieldHelp (actually it is still used at
one single place: in the perms module where it decides whether the legend
in edit mode is displayed or not)
* some unneeded fields are written to uc (user, pwd ...). you could exclude
them by adding a condition like if (!$config['table']) ...
* most of the htmlspecialchars() calls are not needed because they are
applied to strings which are ascii anyway eg. columnnames.
* I see no reason why the fields language and simuser are excluded from CSH


greets
rupert