[TYPO3-core] RFC #7984: Bug: stdWrap.crop now closes opened tags and counts chars correctly

Oliver Hader oliver at typo3.org
Mon Mar 30 17:35:49 CEST 2009


Hi Jochen,

Jochen Rau schrieb:
> Hi,
> 
> Michael Stucki schrieb:
>> Hi Dmitry,
>>
>>> In any case, when 4.3 is out, I will have my own patch pack for it,
>>> which will include this feature. I am really tired of not getting useful
>>> features in because something else "may be better" :( No one is going to
>>> integrate that better feature. So we miss that and this too. No HTML
>>> crop is coming into the official TYPO3 release.
>>
>> The complexity of the patch shows to me why this is still pending. I was
>> able to review it live at T3BOARD09 with Jochen Rau, so every question
>> could be answered right away. However, for things like that this seems
>> to be an absolute must.
> 
> Here comes revised patch with some more comments added.

Find attached a new patch with the following modifications:
* allowed space characters before tag name, e.g "<  a href="..." ...>
* removed some greedy operators, e.g. '"[^"]*' instead of '".*?"'

Furthermore I created some unit tests for the whole thing. The only
thing that is currently missing is the extraction of <script> tags as it
is pointed out in the patch.

Besides the script thingy:
+1 on reading and testing

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0007984_v2.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090330/1f61b546/attachment-0001.ksh 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0007984_tests.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090330/1f61b546/attachment-0001.txt 


More information about the TYPO3-team-core mailing list