[TYPO3-core] RFC #10380: Update t3editor base (CodeMirror) to current release 0.60
Tobias Liebig
mail_news at etobi.de
Mon Mar 2 18:59:18 CET 2009
Dmitry Dulepov schrieb:
> Hi!
>
> Tobias Liebig wrote:
>> The attached patch ...
>> ...
>
> There are four different things. They should be committed separately in order to clearly see where each part ends and another one starts. Suppose there is a critical problem in this large patch. If there is, we will revert the whole patch. If there were 4 different patches, we could revert only one.
>
> I do not like huge patches. I prefer to do as Michael requests: one issue per patch/commit. This is a very careful, good and weighted position. I want all patches to follow that request.
>
> This patch should be split. The RFC number can be one but there should different patches and different commits.
>
i've split up the huge patch into four single patches which should be
easier to review. see attached files
Note: please apply the patches in correct order (a,b,c,d)
a) minor cleanup and rais of version number
b) update codemirror version
c) make usage of the new codemirror api for generating linenumbers
d) remove obsolete bracket-matching
regards
tobias
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_10380d_versionAndCleanup.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090302/ab2110fa/attachment-0004.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_10380a_codemirrorupdate.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090302/ab2110fa/attachment-0005.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_10380b_useLibForLinenums.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090302/ab2110fa/attachment-0006.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_10380c_automatchbrackets.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090302/ab2110fa/attachment-0007.txt
More information about the TYPO3-team-core
mailing list