[TYPO3-core] RFC #10523: New install tool colors, matching t3skin

Rob Vonk typo3 at robvonk.com
Sun Mar 1 11:23:17 CET 2009


Patch works with -p0. Tested on 5108.

I see a tiny markup error on top in 'embedded mode' (see screenshot). In FF 
3.01 on ubuntu. and IE6 on XP (don't have 7). Full install tool mode works 
because the rest of the background is also white.

I see that you changed fixed markup code into css and imho, thats a good 
thing. Is there a reason that you didn't update all table tags (probably 
time). I see some border="0", align="center".

Regards,

Rob

Susanne Moog wrote:
> This is a SVN patch request.
> 
> Type: Feature
> 
> Branches:
> trunk
> 
> BT reference:
> http://bugs.typo3.org/view.php?id=10523
> 
> Problem:
> As the new default TYPO3 skin is t3skin the install tool should match
> that instead of displaying the old colors.
> 
> Solution:
> Attached is a patch that replaces the colors in install tool code with
> css classes and adds a stylesheet to display the new colors.
> Additionally to changing the colors it adjusts the width of the install
> tool to better match current screen resolutions (dynamic scaling to 80%
> screen width, with a max-width for readability).
> 
> Note:
> As I only have Ubuntu and a Wine IE6 I can't really test in IE (or: I
> can't debug as the developer toolbar won't work) so it would be
> especially important to have some IEx tester/debugger.
> 
> I have successfully tested the patch in FF3 and Opera9.63.
> 
> (Attached a cropped screenshot how it looks like)
> 
> Regards,
> 
> Susanne

-------------- next part --------------
A non-text attachment was scrubbed...
Name: install_tool.png
Type: image/png
Size: 16588 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090301/c1359670/attachment.png 


More information about the TYPO3-team-core mailing list