[TYPO3-core] RFC: Bug #6039: TCA group -> file absolute path without uploadfolder (extended)

Christian Kuhn lolli at schwarzbu.ch
Fri Jun 26 15:35:18 CEST 2009


Hey.


- t3lib_admin had errors in the preg_match if
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] ended with '/'. I
added preg_quote in 6039_v12.diff

- I think there is some error in the import, I had the following
testcase: set a reference, export the record, delete the referenced
file, import record. Expected: The file should be added again. Instead
the database reference was set to "typo3temp/import_xyx" (which didn't
exist) and no file was created. I think this is a minor glitch, but
definatly no show stopper for the patch. I'm unsure if we should fix
this now, or maybe in a follow-up?!

Other than that the patch is imho in a pretty good shape.

Here is an additional +0.5 on reading and testing, maybe someone else
could re-read the tce (main & forms) changes to make sure everything is
really ok there.

For your testing convenience I added a simple test extension with two
file fields: One referenced, one not.


Thanks
Christian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6039_v12.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090626/54ead7b3/attachment.txt 


More information about the TYPO3-team-core mailing list