[TYPO3-core] RFC #11608: t3lib_beFunc::viewOnClick - Exctract logic to find the right frontend domain
Oliver Klee
typo3-german-02 at oliverklee.de
Fri Jul 31 15:44:41 CEST 2009
Hi,
could you rework the patch a bit so it's better readable?
- for the @return and the @param, add some descriptions, not only the
type and the name
- $domain is a string, so using it as a boolean is not correct
- two ? operators in a line are confusing
- no abbreviations, please: struct -> structure (or whatever you're
using the abbreviation for)
- space between ) and {
- no spaces after ! or ( or (
- document the special cases of the parameters: whether they may be < =,
zero, empty, null ...
Oliver
More information about the TYPO3-team-core
mailing list