[TYPO3-core] RFC #11539: Bug: t3ver_stage will not be resetted when t3ver_stage was >0 before

[Andreas Wolf]

Hi!

Rupert Germann schrieb:
> the patch works and seems not to have any side effects (access check 
> with workspaceCannotEditRecord() works as before).
> But I'm a little bit unsure (as I don't use workspaces) if this change 
> in behaviour could break something - or if everyone considers the 
> current behaviour as a bug.
> At least the code that resets the stage at only this certain condition 
> was written with an intention.

I suppose (but that's only speculating...) that the intent was to set
content back to edit stage after it was rejected. Perhaps nobody (or at
least not Kasper) thought about somebody editing a "ready for review"
document again?

Btw., as this is workspace/versioning related, Kasper has to approve the
change before it can go into core. At least that was the policy a while
ago, but I don't think it has changed since then - because there's
simply nobody who has fully understood all the concepts behind
versioning/workspaces as implemented in TYPO3.


Regards

Andreas