[TYPO3-core] RFC #11539: Bug: t3ver_stage will not be resetted when t3ver_stage was >0 before

[Rupert Germann]

hi,

the patch works and seems not to have any side effects (access check 
with workspaceCannotEditRecord() works as before).
But I'm a little bit unsure (as I don't use workspaces) if this change 
in behaviour could break something - or if everyone considers the 
current behaviour as a bug.
At least the code that resets the stage at only this certain condition 
was written with an intention.

other opinions?

greets
rupert




Fabrizio Branca schrieb:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=11539
> 
> Branches:
> trunk
> 
> Problem:
> The field t3ver_stage contains workflow information for versionable 
> records. -1 is "rejected", 0 is "edited", 1 is "ready for review", 10 is 
> "reviewed/ready for publish".
> If a record will be edited the stage will be only resetted to 0 if it 
> was rejected (-1) before. If a record is in stage 1 or even 10 it should 
> be resetted to 0 too when being edited. If not the publisher would 
> publish an edited version, that wasn't re-reviewed, which should not be 
> possible in a workflow scenario.
> 
> Solution:
> Reset t3ver_stage in t3lib_TCEmain::process_datamap() in any case and 
> not only if t3ver_stage was <0 before
> 
> Bye,
> 
> Fabrizio
>