[TYPO3-core] RFC: #11487: Feature: Open InlineHelp in Ext Js non-modal windows

Martin Kutschker masi-no at spam-typo3.org
Tue Jul 7 15:56:50 CEST 2009


Steffen Kamper schrieb:
> 
>> And Steffen I wondered when you showed the code to me why the window
>> opening is done via via DOM manipulating instead by generating a
>> different window-open function. As you had to change the code that
>> generates the links you could have done it easily in this way. This has
>> the advantage that you can pass JS-window-open parameters for the
>> open-in-new-window feature.
>>
> 
> it's the source i showed to you ;) Here it is a register process, where
> popup types are passed with their dimensions. There is no DOM
> manipulation, only event catching, there a new window is created.

OK, no DOM manipulation. What I meant was why has the client to do some
processing if the server can do it without extra work. But I have no
strong opinion on this. Yet I feel that moving too much stuff the client
will bog down the browsers. Anyway this is an implementation detail.
That can be changed later quite easily.

>> Something else I would like to change see is the open method of the
>> IframeWindow class - BTW, how do we protected our ux classes from the
>> ones in the wild? * - it resembles neither the JS window function nor
>> the standard ExtJS signature of "option" parameters. How about open(url,
>> target, options) where "options" is an array. Options takes all options
>> from Ext.window and JS window open (perhaps with a "javascript"
>> sub-array to pass stuff that might be different for the JS-window from
>> the Ext.window (like height and width).
> 
> the class is different to an object which is used in a context. So the
> few params are passed in the register method. If you have a better idea,
> try it. As this is the "first" ux for core we may find common solutions
> later anyway.

I'm not sure I understand you or if you have understood me ;) I'll try
to see if I can write a code to show what I  mean.

>> And added benefit would be the possibility for a TYPO3.open function
>> where target could be '_iframe'. Instead of a JS-window open it would
>> use the iframe class to open the url.
> 
> you can register any link with this class. Here selector is class, but
> you can choose any available selector like target, rel etc.

Again,  a matter of style. I like to be in *direct* control over what
happens instead of relying  on some magic although I see the beauty of
adding the ExtJS Iframe window to any link by registering the handler.
Too bad one is loosing all the styling options you have when using
vanilla window.open.

Masi


More information about the TYPO3-team-core mailing list