[TYPO3-core] RFC Bug #11450: Install tool access check should take IPv6 loopback into account

Sebastian Fischer sebastian at fischer.im
Mon Jul 6 17:34:15 CEST 2009


Mario Rimann schrieb:
> Hi
> 
> Oliver Klee schrieb:
>> -1 on reading because the closing parenthesis is at the wrong place:
> 
> yes, good catch!
> 
>> To make this clearer, you could ...
>>   1. fix the parenthesis :-)
>>   2. break the line to be shorter than 80 characters (if possible,
>>      use line breaks in a way to make the structure of the condition
>>      clearer)
>>   3. use spaces around the == and !=
>>   4. use parenthesis around the sub conditions
> 
> The attached patch corrects all of the above points (and I hope that
> this is correct regarding the CGL).
> 
> Cheers,
> Mario
> 

Hi Mario,

+1 by reading

and another +1 for formating according the CGL ;)

Greetings
Sebastian


More information about the TYPO3-team-core mailing list