[TYPO3-core] RFC #10220: Feature: Get some unit tests for the core

Steffen Kamper info at sk-typo3.de
Thu Jan 22 17:39:40 CET 2009


Hi Dmitry,

Dmitry Dulepov schrieb:
> Hi!
> 
> Oliver Klee wrote:
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=10220 (core patch)
>> http://forge.typo3.org/issues/show/2503 (phpunit patch)
>>
>> Branches: trunk
>>
>> Problem:
>> The core badly needs some unit tests. This patch provides the first
>> handful of them as a start.
>>
>> Solution:
>> Add some unit first tests.
> 
> The feature is very welcome! I'll test it soon and give my +1 unless someone else can do it faster.
>

it's already ready for commit with my and Peter's +1

> What I enjoyed/disliked (50/50) in the patch is this function name:
> 
> testCheckModifyAccessListForNonAdminWithTableModifyAccessForBeUsersTableReturnsFalse()
> 
> Reminds me one of my favorite web sites:
> http://www.millionreasonswhylatviaisthebestcountryintheworld.com/
> 

i don't see a problem with this long names as tests must be reflected in 
names, and with this example i like it more than abbr. like
testModAccList...
but of course it looks funny :-)

vg Steffen


More information about the TYPO3-team-core mailing list