[TYPO3-core] RFC: #9991: Localize versioning module

[Christoph Niewerth]

Hi Stefano

Attached a new patch, taking your comments into account.

Stefano Kowalke wrote:
> Line 449:
> - <td>Title</td>
> + <td>' . $GLOBALS['LANG']->getLL('tblTitle') . '</td>
> 
> Maybe it is better to take the exist label from
> locallang_general.xml:LGL.title or create 'Title' in locallang_common.xml
> 
> Line 450 and 457:  
> <td>UID</td>
> <td>pid</td>
> 
> Need a translation too for reason if you want to translate into a non-latin
> chars language

Taken Christians comment into account. Now table headers and their 
titles can be changed in locallang.xml.

> Line 473 and 476:
> <img'.t3lib_iconWorks::skinImg($this->doc->backPath,'gfx/insert4.gif','width="14"
> height="14"').' alt="" title="Publish page AND content! - AND ALL
> SUBPAGES!" />

The lines are commented out. I think a localisation of these are not 
essential. There is a ternary operator over several lines, that should 
be cleaned up in another rfc.

> Line 488 and 620:
> 
> Take the label 'Edit' from locallang_common instead
Was already done in v2-diff.

> Line 517:
> Label: <input type="text" name="cmd['.$this->table.']['.$this->uid.'
> [version][label]" /><br/>
Done.

> Line 625:
> 
> Take the label 'Delete' from locallang_common instead
Was already done in v2-diff.

> Line 712:
> 
> Make label 'Errors:' translateable
Done.

> Line 893:
> - $diffCode.= ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct.'% change:' : ''));
> + $diffCode.= ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct . '% ' .
> $GLOBALS['LANG']->getLL('change') : ''));
> 
> Make label 'N/A' translateable
Done.

> Line 923:
> - // Create version element:
> + // Create version element:          $GLOBALS['LANG']->getLL('liveVersion')
> 
> Don't understand this.  $GLOBALS['LANG']->getLL('liveVersion') is commented
> out.
Removed this hunk.

> Line 1407:
> - ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct.'% change:' : '')).
> + ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct . '% ' .
> $GLOBALS['LANG']->getLL('change') : '')).
> 
> Make 'N/A' translateable
Done.

Sincerely yours
Christoph Niewerth
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9991_v3.diff
Type: text/x-patch
Size: 43571 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090122/0f3e0ab1/attachment-0001.bin