[TYPO3-core] RFC: #9991: Localize versioning module

Stefano Kowalke blueduck at gmx.net
Thu Jan 15 23:18:18 CET 2009


Hi Steffen,

i found some issues they need to fix:

Line 449:
- <td>Title</td>
+ <td>' . $GLOBALS['LANG']->getLL('tblTitle') . '</td>

Maybe it is better to take the exist label from
locallang_general.xml:LGL.title or create 'Title' in locallang_common.xml

Line 450 and 457:  
<td>UID</td>
<td>pid</td>

Need a translation too for reason if you want to translate into a non-latin
chars language

Line 473 and 476:
<img'.t3lib_iconWorks::skinImg($this->doc->backPath,'gfx/insert4.gif','width="14"
height="14"').' alt="" title="Publish page AND content! - AND ALL
SUBPAGES!" />

Line 488 and 620:

Take the label 'Edit' from locallang_common instead


Line 517:
Label: <input type="text" name="cmd['.$this->table.']['.$this->uid.'
[version][label]" /><br/>



Line 625:

Take the label 'Delete' from locallang_common instead


Line 712:

Make label 'Errors:' translateable


Line 893:
- $diffCode.= ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct.'% change:' : ''));
+ $diffCode.= ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct . '% ' .
$GLOBALS['LANG']->getLL('change') : ''));

Make label 'N/A' translateable

Line 923:
- // Create version element:
+ // Create version element:          $GLOBALS['LANG']->getLL('liveVersion')

Don't understand this.  $GLOBALS['LANG']->getLL('liveVersion') is commented
out.

Line 1407:
- ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct.'% change:' : '')).
+ ($diffPct<0 ? 'N/A' : ($diffPct ? $diffPct . '% ' .
$GLOBALS['LANG']->getLL('change') : '')).

Make 'N/A' translateable


Cheers 
Stefano
-- 
Seit dem 1.1.2008 werden Daten zu jeder E-Mail verdachtsunabhängig gespeichert! 
Weitere Informationen: www.vorratsdatenspeicherung.de
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D


More information about the TYPO3-team-core mailing list